[PATCH] D51841: [llvm-objcopy] Dwarf decompression support.

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 14 10:56:35 PDT 2018


plotfi marked 18 inline comments as done.
plotfi added inline comments.


================
Comment at: tools/llvm-objcopy/Object.h:405
+        DecompressedAlign(Sec.DecompressedAlign) {
+    Size = DecompressedSize;
+    Flags = (Flags & ~ELF::SHF_COMPRESSED);
----------------
jhenderson wrote:
> plotfi wrote:
> > Oops, I think I need to add Align = DecompressedAlign here. What do you think @jakehehrlich 
> What is DecompressedAlign actually used for? You should certainly be setting Align.
I'm not actually completely sure. But it's in the ELF Chdr so I believe it's just encoding the alignment of the section from what be was before being compressed. 


Repository:
  rL LLVM

https://reviews.llvm.org/D51841





More information about the llvm-commits mailing list