[PATCH] D52095: Introduce explicit add_file_reading_unittest target for tests that use llvm::getInputFileDirectory()
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 14 10:37:41 PDT 2018
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
r342248, thanks!
================
Comment at: unittests/DebugInfo/PDB/CMakeLists.txt:7
-add_llvm_unittest(DebugInfoPDBTests
+add_llvm_file_reading_unittest(DebugInfoPDBTests
HashTableTest.cpp
----------------
zturner wrote:
> Can you call this `add_llvm_unittest_with_input_files`? The distinction is subtle, but we already have plenty of unittests that read files and don't need this functionality (specifically, most of the tests of `Support/FileSystem.h` itself. This way it's clear what's being read.
Good suggestion, thanks.
https://reviews.llvm.org/D52095
More information about the llvm-commits
mailing list