[PATCH] D51561: [CMake] Add support for unittests that have input files

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 14 08:00:49 PDT 2018


thakis added a comment.

In https://reviews.llvm.org/D51561#1234862, @zturner wrote:

> All of the lit tests have this restriction, is this something you would do
>  with unit tests but not lit tests?


If you set things up so that the paths passed to lit.site.cfg.py.in (@LLVM_SOURCE_DIR@ etc) are relative and are made absolute at test time instead of at cmake time, this currently works. But treating the contents of llvm.srcdir.txt as executable-relative paths does make things work in that setup, so I have a workaround for that usecase.

I sent you https://reviews.llvm.org/D52095 for making the file-reading opt-in as I requested.


Repository:
  rL LLVM

https://reviews.llvm.org/D51561





More information about the llvm-commits mailing list