[PATCH] D52094: lld: add -z interpose support

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/dt_flags.s:10-13
+# RUN: ld.lld -z interpose \
+# RUN:   -Bsymbolic %t %t.so -o %t1
+# RUN: llvm-readobj -dynamic-table %t1 | FileCheck -check-prefix=INTERPOSE %s
+
----------------
emaste wrote:
> I think it makes sense to validate flags individually to ensure we don't mix up bits or accidentally set flags we shouldn't, but I will just add it to the list in `FLAGS:` above if that's desired.
I would be consistent with the existent test and reuse `FLAGS`


================
Comment at: test/ELF/dt_flags.s:11
+# RUN: ld.lld -z interpose \
+# RUN:   -Bsymbolic %t %t.so -o %t1
+# RUN: llvm-readobj -dynamic-table %t1 | FileCheck -check-prefix=INTERPOSE %s
----------------
This could be a single line:

ld.lld -z interpose -Bsymbolic %t %t.so -o %t1


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52094