[PATCH] D47858: [New PM] Introducing PassInstrumentation framework

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: include/llvm/IR/PassInstrumentation.h:70
+/// that need to track pass execution.
+class PassExecutionCounter {
+  unsigned count = 0;
----------------
philip.pfaffe wrote:
> Is this still required?
if I got Chandler right he asked me to keep it around for individual callbacks use.
I'm really not sure that it is needed anymore.


================
Comment at: include/llvm/IR/PassInstrumentation.h:146
+      : Callbacks(CB) {}
+  PassInstrumentation(const PassInstrumentation &) = default;
+
----------------
philip.pfaffe wrote:
> Is this necessary?
you mean the default copy? perhaps not. will delete it.


================
Comment at: include/llvm/IR/PassManagerInternal.h:89
+
+  PassInstancePtr getPassInstance() const override { return &Pass; }
 
----------------
philip.pfaffe wrote:
> Is this still required?
definitely not


Repository:
  rL LLVM

https://reviews.llvm.org/D47858