[PATCH] D51908: [DebugInfo] Do not generate debug info for removed labels.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 14 03:36:09 PDT 2018


probinson added a comment.

In https://reviews.llvm.org/D51908#1233588, @dblaikie wrote:

> Perhaps we could implement this behavior (pr: i.e., omitting the label if it has been optimized away) only if we're tuning for GDB & otherwise produce a label without a low_pc? Not sure how other folks (@aprantl @echristo @probinson @JDevlieghere) feel about this - apply the workaround generally, because it's not super important to have a label for name-lookup porpoises? or is it worth carrying the two codepaths to ensure that slightly more accurate debug info where it's possible (presuming LLDB can cope with it)?


Special cases for GDB bugs are not great.  While on principle I'd rather see the entry with no location, I agree it's not super important to keep it and it's less grody to behave the same for all tunings here.


Repository:
  rL LLVM

https://reviews.llvm.org/D51908





More information about the llvm-commits mailing list