[PATCH] D52051: [LLD] [COFF] Avoid copying of chunk vectors. NFC.

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 13 15:32:23 PDT 2018


smeenai added inline comments.


================
Comment at: COFF/Writer.cpp:472
   // contributes to .text, for example. See PE/COFF spec 3.2.
-  for (auto Pair : Map) {
+  for (auto &Pair : Map) {
     StringRef Name = getOutputSectionName(Pair.first.first);
----------------
Could this be `const`?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52051





More information about the llvm-commits mailing list