[PATCH] D51981: lld-link: If an input file doesn't exist, don't print diagnostics after "input file doesn't exist".

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 13 11:15:08 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rLLD342158: lld-link: For nonexisting inputs, omit follow-on diagnostics (authored by nico, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D51981?vs=165074&id=165336#toc

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51981

Files:
  COFF/Driver.cpp
  test/COFF/could-not-open.test


Index: test/COFF/could-not-open.test
===================================================================
--- test/COFF/could-not-open.test
+++ test/COFF/could-not-open.test
@@ -0,0 +1,5 @@
+RUN: not lld-link 01 2>&1 | FileCheck %s
+
+CHECK:     could not open 01
+CHECK-NOT: /machine is not specified
+CHECK-NOT: subsystem must be defined
Index: COFF/Driver.cpp
===================================================================
--- COFF/Driver.cpp
+++ COFF/Driver.cpp
@@ -1236,6 +1236,9 @@
   // Read all input files given via the command line.
   run();
 
+  if (errorCount())
+    return;
+
   // We should have inferred a machine type by now from the input files, but if
   // not we assume x64.
   if (Config->Machine == IMAGE_FILE_MACHINE_UNKNOWN) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51981.165336.patch
Type: text/x-patch
Size: 757 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180913/2a8aa635/attachment.bin>


More information about the llvm-commits mailing list