[PATCH] D51936: Fix a use-after-RAUW bug in large GEP splitting
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 13 11:08:51 PDT 2018
efriedma added inline comments.
================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:281
/// size.
- DenseMap<
- AssertingVH<Value>,
+ ValueMap<
+ Value*,
----------------
Please add a comment explaining why the keys can be RAUW'ed, but the values can't.
Please add a comment explaining what happens if the result of the RAUW already exists in the map... or if that isn't possible, why it isn't possible.
Repository:
rL LLVM
https://reviews.llvm.org/D51936
More information about the llvm-commits
mailing list