[PATCH] D52024: LSV: Fix adjust alloca alignment trick for AMDGPU

[Benjamin Kramer via Phabricator via llvm-commits]

bkramer accepted this revision.
bkramer added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:995-997
     unsigned NewAlign = getOrEnforceKnownAlignment(S0->getPointerOperand(),
                                                    StackAdjustedAlignment,
                                                    DL, S0, nullptr, &DT);
----------------
arsenm wrote:
> I guess this can result in increasing the alignment even if nothing is going to end up vectorized, but that's probably not that important
I think this is fine. It's a bit awkward but not a big deal. It would be better to ask for an alignment that's actually going to help instead of StackAdjustedAlignment but that's out of scope or this change.


https://reviews.llvm.org/D52024