[PATCH] D51798: [Dwarf/AArch64] Return address signing B key dwarf support

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

Before I review the code itself, have you agreed the .append_augmentation directive with the GCC/GAS developers to make sure we implement it the same way?

If the design isn't yet set in stone, I have a few comments on it:

- Why doesn't it begin with ".cfi_", while every other related directive does? There's a complete list of them at https://sourceware.org/binutils/docs/as/CFI-directives.html
- Why are we adding a generic directive to append to the augmentation string, rather than a directive to select the B key? This looks very similar to .cfi_signal_frame, which also adds one character to the augmentation string.


https://reviews.llvm.org/D51798