[PATCH] D52025: [TargetLowering] Android has sincos functions

Thu Sep 13 05:11:43 PDT 2018

john.brawn added inline comments.

================
Comment at: lib/CodeGen/TargetLoweringBase.cpp:165
-  if (TT.isGNUEnvironment() || TT.isOSFuchsia()) {
+  if (TT.isGNUEnvironment() || TT.isOSFuchsia() ||
+      (TT.isAndroid() && !TT.isAndroidVersionLT(9))) {
     setLibcallName(RTLIB::SINCOS_F32, "sincosf");
     setLibcallName(RTLIB::SINCOS_F64, "sincos");
----------------
xbolva00 wrote:
> I think there should be SDK version.. sdk 28.
I do actually mean 9 here. It looks like sincos was added by https://android.googlesource.com/platform/bionic/+/ddd235bd9c264f08dee7887e210d61ca2351cf86 and https://android.googlesource.com/platform/bionic/+/9946750609c858dad0150da55645c4331392cf0d which first appeared in Android 2.3 which is API version 9.

Repository:
  rL LLVM

https://reviews.llvm.org/D52025