[PATCH] D51973: [New PM] adding unit tests for PassInstrumentation

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 13 04:37:49 PDT 2018


philip.pfaffe added a comment.

This looks good! I dislike the AnyNumber() expecations you highlighted above, but I see that it's unavoidable without either repeating a lot of the test logic again, or without waiting for something like https://reviews.llvm.org/D39678 to happen.


Repository:
  rL LLVM

https://reviews.llvm.org/D51973





More information about the llvm-commits mailing list