[PATCH] D51995: AMDGPU: Generate VALU ThreeOp Integer instructions

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 13 02:08:29 PDT 2018


nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/VOP3Instructions.td:524
+class ThreeOp_i32_Pats <SDPatternOperator op1, SDPatternOperator op2, Instruction inst> : GCNPat <
+  (ThreeOpFrag<op1, op2> i32:$src0, i32:$src1, i32:$src2), //(op2 (op1 i32:$src0, i32:$src1), i32:$src2),
+  (inst i32:$src0, i32:$src1, i32:$src2)
----------------
rampitec wrote:
> Remove commented code.
Ah, I thought the idea was to comment what this matches. I'm making this clearer.


Repository:
  rL LLVM

https://reviews.llvm.org/D51995





More information about the llvm-commits mailing list