[PATCH] D51841: [llvm-objcopy] Dwarf decompression support.

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 13 01:36:02 PDT 2018


alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/Object.h:382
+
+  void enableDecompression() {
+    DoDecompression = true;
----------------
oh, no, that's not what i meant tbh, and this looks kinda strange (i mean the class with this method), although maybe I'm missing smth.
When I said that probably it would make sense to introduce DecompressedSection I meant that the approach would be in some sense "dual" to what you did for compression in the previous review.  What are your thoughts ?


Repository:
  rL LLVM

https://reviews.llvm.org/D51841





More information about the llvm-commits mailing list