[PATCH] D52002: Switch optimization for known maximum switch values
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 12 14:59:58 PDT 2018
spatel edited reviewers, added: hans, bkramer; removed: spatel.
spatel added a comment.
I don't know enough about switch lowering to review this, so adding some more potential reviewers.
But there are at least a couple of obvious changes needed before this can proceed:
1. The patch must include tests that show the difference with this patch.
2. The indentation and spacing are clearly off (use clang-format?), and variable naming doesn't conform with: http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
Repository:
rL LLVM
https://reviews.llvm.org/D52002
More information about the llvm-commits
mailing list