[PATCH] D51958: [PDB] Emit old fpo data to the PDB

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 13:08:57 PDT 2018


rnk added a comment.

Needs tests? Maybe they just aren't in the diff?



================
Comment at: lld/COFF/PDB.cpp:845-846
+  ArrayRef<uint8_t> Result = makeArrayRef(Buffer, DebugChunk.getSize());
+  if (HasMagic)
+    Result = consumeDebugMagic(Result, DebugChunk.getSectionName());
+  return Result;
----------------
I think we can raise this into handleDebugS and then we don't need the `HasMagic` parameter.


https://reviews.llvm.org/D51958





More information about the llvm-commits mailing list