[PATCH] D51089: [LLD] [COFF] Add support for creating range extension thunks for ARM

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo updated this revision to Diff 165136.
mstorsjo added a comment.

Optimized the algorithm further by checking ranges with a margin in the first pass, making it succeed after the first run in my testcase. Shortened a variable name and added whitespace as @ruiu suggested.

The testcase isn't updated after the last adjustments though - it's pretty much work to hand craft a testcase which triggers as many of the cornercases of the algorithm, I'll update it once we settle on the algorithm to choose.

Since using a margin for adding thunks, I think it will be extremely tedious to actually create a testcase which would trigger more than one pass.


https://reviews.llvm.org/D51089

Files:
  COFF/Chunks.cpp
  COFF/Chunks.h
  COFF/PDB.cpp
  COFF/Writer.cpp
  COFF/Writer.h
  test/COFF/Inputs/far-arm-thumb-abs.s
  test/COFF/Inputs/far-arm-thumb-abs20.s
  test/COFF/arm-thumb-branch-error.s
  test/COFF/arm-thumb-branch20-error.s
  test/COFF/arm-thumb-thunks.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51089.165136.patch
Type: text/x-patch
Size: 21159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180912/b37c5843/attachment.bin>