[PATCH] D51918: [Support] sys::fs::directory_entry includes the file_type.

[Sam McCall via Phabricator via llvm-commits]

sammccall added a comment.

In https://reviews.llvm.org/D51918#1232281, @kristina wrote:

> Style consistency.
>
>   Variable names should be nouns (as they represent state). The name should be camel case, and start with an upper case letter (e.g. Leader or Boats).
>
>
> If possible please fix existing naming violations in functions which this patch modifies, as well as newly introduced violations.


Yep. I was aiming for consistency with the surrounding code, since the whole file (including its public APIs) are using an old style.
I've now instead changed all the locals in affected functions to use UpperCamelCase, as well as a couple of static helper functions. I haven't changed public function names etc, or the other functions in the same file.

Because I can't build the code in Windows/Path.inc, I'm concerned all this renaming may have introduced errors, but that's what buildbots are for I guess.


Repository:
  rL LLVM

https://reviews.llvm.org/D51918