[PATCH] D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track.

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 10:35:21 PDT 2018


george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM, modulo one nit. Thanks!



================
Comment at: test/Transforms/EarlyCSE/preserve_memoryssa.ll:2
+; RUN: opt < %s -early-cse-memssa -verify-memoryssa -disable-output
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
Can we disable this if asserts are off, since verifyMemorySSA() will do nothing without asserts?

Looks like `; REQUIRES: asserts` might be what we want, but I've never used it myself.


Repository:
  rL LLVM

https://reviews.llvm.org/D51960





More information about the llvm-commits mailing list