[PATCH] D51887: lld-link: Set PDB GUID to hash of PDB contents instead of to a random byte sequence.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

> Did some measurements on my linux box (didn't have access to my win box). There, just naively calling xxHash64 on the 1.4GB chrome.dll.pdb file after creating it, doing the parallel xxHas64 computation, this patch, and the old nondeterministic guid code all take about the same amount of time (around 32s, min-of-4 links with each approach is within 0.2s of that). I'll try this on Windows tomorrow.

If it is so cheap to compute a hash, maybe we should use MD5 instead of xxhash to eliminate the possibility of hash collision?


https://reviews.llvm.org/D51887