[PATCH] D51968: [deadargelim] Update dbg.value of 'unused' parameters

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Thanks, this looks mostly good, minor comments for the testcase inline.

Why doesn't this do the right thing automatically though? What does the dbg.value point to after %k is dropped?



================
Comment at: test/Transforms/DeadArgElim/dbginfo-update-dbgval.ll:27
+entry:
+; CHECK: call void @llvm.dbg.value(metadata i32 undef, metadata !15, metadata !DIExpression()), !dbg !16
+  call void @llvm.dbg.value(metadata i32 %k, metadata !15, metadata !DIExpression()), !dbg !16
----------------
can you also add a check that f2 no longer has an argument?


================
Comment at: test/Transforms/DeadArgElim/dbginfo-update-dbgval.ll:79
+!20 = !{!"omnipotent char", !21, i64 0}
+!21 = !{!"Simple C/C++ TBAA"}
+!22 = !DILocation(line: 6, column: 1, scope: !11)
----------------
You can probably strip out all TBAA metadata, it just distracts in this testcase.


Repository:
  rL LLVM

https://reviews.llvm.org/D51968