[PATCH] D51965: [XRay] Bug fixes for FDR custom event and arg-logging

[Marcus Boerger via Phabricator via llvm-commits]

mboerger added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_fdr_logging.cc:293
+  // to the first 28 bits -- this means we need to mask the function id with (2
+  // ^ 28) - 1, or 0xfffffff.
+  //
----------------
Put the formula on one line and maybe state that the number is 0x0FFFFFFFF


================
Comment at: compiler-rt/lib/xray/xray_fdr_logging.cc:623
   //          id" MetadataRecord before writing out the actual FunctionRecord.
-  //       4. The second MetadataRecord is the optional function call argument.
+  //       4. The third MetadataRecord is the optional function call argument.
   //
----------------
what about the 'second'


https://reviews.llvm.org/D51965