[PATCH] D51923: [NFC] Add validation to Ordered Instructions
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 11 22:32:06 PDT 2018
mkazantsev added a comment.
Thanks @fhahn , I haven't seen it before. Actually after studying the code I came to the same conclusions as they did (that we only need to invalidate when we insert instructions or remove blocks). The mental problem I have is the comment for this class stating that: "A OrderedBasicBlock instance should be discarded whenever the source BasicBlock changes". This, in particular, means that I can check that we don't have dangling pointers whenever we make a request to this class...
I'll go read this patch.
https://reviews.llvm.org/D51923
More information about the llvm-commits
mailing list