[PATCH] D50820: [VPlan] Implement initial vector code generation support for simple outer loops.

[Satish K Guggilla via Phabricator via llvm-commits]

sguggill marked an inline comment as done.
sguggill added inline comments.


================
Comment at: lib/Transforms/Vectorize/VPlan.cpp:392
+    for (VPBlockBase *SuccVPBlock : VPBB->getHierarchicalSuccessors()) {
+      VPBasicBlock *SuccVPBB = SuccVPBlock->getExitBasicBlock();
+      BBTerminator->setSuccessor(Idx, State->CFG.VPBB2IRBB[SuccVPBB]);
----------------
rkruppe wrote:
> Shouldn't this call `getEntryBasicBlock()`? If the successor is a region, the corresponding IR block should jump to the entry block of that region, not to its exit.
Thank you for pointing this out. This was an oversight. The code was working as all successors were VPBasicBlocks in VPlanNativePath at this point. I have fixed this.


Repository:
  rL LLVM

https://reviews.llvm.org/D50820