[PATCH] D51953: [GlobalISel] Add a new IR canonicalization pass

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Amara,

Thanks for putting this up.

I like the general approach.

Couple of open questions:

- Given this is canonicalization as opposed to optimization, shouldn't this be mandatory? I.e., if GISel runs, this runs. Alternatively, should we use another name not to imply this is mandatory (like beautification, I know this is ugly :P).
- Given this runs on IR, I assume we won't need something similar at the MIR level, is that correct?
- Given this runs on IR, I am guessing there are/will be some redundant code with InstCombine. Could/should we move the core of the logic in a separate library/file that could be called directly by this pass and InstCombine.
- This kind of canonicalization could be useful to other ISels, should we make this a mandatory pass period? I.e., not tie to GISel at all.

Cheers,
-Quentin


Repository:
  rL LLVM

https://reviews.llvm.org/D51953