[PATCH] D51941: [Support] Avoid calling CommandLineToArgvW from shell32.dll
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 11 14:31:22 PDT 2018
rnk added a comment.
Unfortunately, it looks like this changed the behavior of newlines embedded in arguments. When parsing response files, we want to treat \n as whitespace. When parsing a command line, CommandLineToArgvW apparently does not. The documentation says it separates arguments on "whitespace characters", but it doesn't say what it considers to be whitespace. Apparently \n is not whitespace.
In the meantime, I made LLVM quote newlines in arguments to fix the clang tests that relied on this behavior in https://reviews.llvm.org/rL341992.
Repository:
rL LLVM
https://reviews.llvm.org/D51941
More information about the llvm-commits
mailing list