[PATCH] D51885: [CMake] [MinGW] Build address sanitizer for MinGW

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: cmake/config-ix.cmake:517
     (OS_NAME MATCHES "Android|Darwin|Linux|FreeBSD|NetBSD|OpenBSD|Fuchsia|SunOS" OR
-    (OS_NAME MATCHES "Windows" AND (NOT MINGW AND NOT CYGWIN))))
+    (OS_NAME MATCHES "Windows" AND NOT CYGWIN)))
   set(COMPILER_RT_HAS_SANITIZER_COMMON TRUE)
----------------
I guess this should be extended into something that allows building it with mingw+clang, but not with mingw+gcc, in case there are existing cases where this is project is built in that configuration, since this would otherwise break it by trying to build something that isn't supported?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51885