[PATCH] D51892: Revert "Also demote lazy symbols."

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

We generally don't check in a binary file unless there's no way to generate a file from text. Looks like we already have a test that creates a .gnu.linkonce section, see test/ELF/comdat-linkonce.s. Could you create a test based on it?



================
Comment at: test/ELF/i386-linkonce.s:3
+// RUN: llvm-mc -filetype=obj -triple=i386-linux-gnu %s -o %t.o
+// RUN: not ld.lld %t.o %p/Inputs/i386-glibc-strchr.a -o %t 2>&1 | FileCheck %s
+
----------------
Please write a test that is expected to succeed to make it more reliable.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51892