[PATCH] D51914: [ASan] [Windows] Avoid including windows.h in asan_malloc_win.cc

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 11 13:16:04 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/asan/asan_malloc_win.cc:17
 #if SANITIZER_WINDOWS
 #define WIN32_LEAN_AND_MEAN
+
----------------
We can drop this define, it's just intended to reduce windows.h transitive includes.


================
Comment at: lib/asan/asan_malloc_win.cc:27-28
+
+#define HEAP_ZERO_MEMORY           0x00000008
+#define HEAP_REALLOC_IN_PLACE_ONLY 0x00000010
+
----------------
Hm, these two constants are not as obvious as the typedefs. Oh well.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51914





More information about the llvm-commits mailing list