[PATCH] D51893: [X86] Teach X86SelectionDAGInfo::EmitTargetCodeForMemcpy about GNUX32

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 11 12:40:06 PDT 2018


efriedma added inline comments.


================
Comment at: test/CodeGen/X86/pr38865.ll:24
+; CHECK-NEXT:    movl %ebx, %esi
+; CHECK-NEXT:    rep;movsl
+; CHECK-NEXT:    callq d
----------------
craig.topper wrote:
> efriedma wrote:
> > Shouldn't this be `rep;movsl (%esi), (%edi)`, to get the right encoding?
> Are you saying we should be using the 0x67 adsize prefix?
Yes, to be consistent with other memory operations.


https://reviews.llvm.org/D51893





More information about the llvm-commits mailing list