[llvm] r341972 - [X86] Teach X86FastISel::X86SelectRet to use EAX for the sret pointer in GNUX32

[Craig Topper via llvm-commits]

Author: ctopper
Date: Tue Sep 11 10:57:23 2018
New Revision: 341972

URL: http://llvm.org/viewvc/llvm-project?rev=341972&view=rev
Log:
[X86] Teach X86FastISel::X86SelectRet to use EAX for the sret pointer in GNUX32

GNUX32 uses 32-bit pointers despite is64BitMode being true. So we should use EAX to return the value.

Fixes ones of the failures from PR38865.

Differential Revision: https://reviews.llvm.org/D51940

Added:
    llvm/trunk/test/CodeGen/X86/pr38865-2.ll
Modified:
    llvm/trunk/lib/Target/X86/X86FastISel.cpp

Modified: llvm/trunk/lib/Target/X86/X86FastISel.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FastISel.cpp?rev=341972&r1=341971&r2=341972&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86FastISel.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86FastISel.cpp Tue Sep 11 10:57:23 2018
@@ -1278,7 +1278,7 @@ bool X86FastISel::X86SelectRet(const Ins
     unsigned Reg = X86MFInfo->getSRetReturnReg();
     assert(Reg &&
            "SRetReturnReg should have been set in LowerFormalArguments()!");
-    unsigned RetReg = Subtarget->is64Bit() ? X86::RAX : X86::EAX;
+    unsigned RetReg = Subtarget->isTarget64BitLP64() ? X86::RAX : X86::EAX;
     BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc,
             TII.get(TargetOpcode::COPY), RetReg).addReg(Reg);
     RetRegs.push_back(RetReg);

Added: llvm/trunk/test/CodeGen/X86/pr38865-2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/pr38865-2.ll?rev=341972&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/pr38865-2.ll (added)
+++ llvm/trunk/test/CodeGen/X86/pr38865-2.ll Tue Sep 11 10:57:23 2018
@@ -0,0 +1,23 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -O0 -mtriple=x86_64-unknown-linux-gnux32 | FileCheck %s
+
+target datalayout = "e-m:e-p:32:32-i64:64-f80:128-n8:16:32:64-S128"
+
+%struct.a = type { i8 }
+
+define void @_Z1bv(%struct.a* noalias sret %agg.result) {
+; CHECK-LABEL: _Z1bv:
+; CHECK:       # %bb.0: # %entry
+; CHECK-NEXT:    pushq %rax
+; CHECK-NEXT:    .cfi_def_cfa_offset 16
+; CHECK-NEXT:    movl %edi, %eax
+; CHECK-NEXT:    movl %eax, {{[-0-9]+}}(%e{{[sb]}}p) # 4-byte Spill
+; CHECK-NEXT:    callq _Z1bv
+; CHECK-NEXT:    movl {{[-0-9]+}}(%e{{[sb]}}p), %eax # 4-byte Reload
+; CHECK-NEXT:    popq %rcx
+; CHECK-NEXT:    .cfi_def_cfa_offset 8
+; CHECK-NEXT:    retq
+entry:
+  call void @_Z1bv(%struct.a* sret %agg.result)
+  ret void
+}