[PATCH] D48826: [AMDGPU] Add support for TFE/LWE in image intrinsics
David Stuttard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 11 10:31:50 PDT 2018
dstuttard updated this revision to Diff 164921.
dstuttard added a comment.
Folded in most of the changes highlighted in the review
There are also several new changes to the original patch in light of bugs
uncovered during further testing with applications using the support.
I haven't attempted to implement Matt's suggestion of using a struct return type
or 5-vec support. Could we add that as something to do at a later date?
Nicolai, do you have any feedback on that piece of work - my feeling is that it
is quite a complicated change based on how the intrinsics are defined. If not, I
can take another look if you can give some pointers.
Repository:
rL LLVM
https://reviews.llvm.org/D48826
Files:
lib/Target/AMDGPU/AMDGPU.h
lib/Target/AMDGPU/AMDGPU.td
lib/Target/AMDGPU/AMDGPUSubtarget.cpp
lib/Target/AMDGPU/AMDGPUSubtarget.h
lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
lib/Target/AMDGPU/CMakeLists.txt
lib/Target/AMDGPU/MIMGInstructions.td
lib/Target/AMDGPU/SIAddIMGInit.cpp
lib/Target/AMDGPU/SIISelLowering.cpp
lib/Target/AMDGPU/SIInstrInfo.cpp
lib/Transforms/InstCombine/InstCombineInternal.h
lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
test/CodeGen/AMDGPU/llvm.amdgcn.image.dim.ll
test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.d16.dim.ll
test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.dim.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48826.164921.patch
Type: text/x-patch
Size: 52409 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180911/0ef2ee14/attachment-0001.bin>
More information about the llvm-commits
mailing list