[PATCH] D50200: AMDGPU: Handle "uniform-work-group-size" attribute
Aakanksha Patil via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 11 10:01:02 PDT 2018
aakanksha555 marked 4 inline comments as done.
aakanksha555 added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:244-245
+ //Check for uniform workgroup size attribute
+ if (F.hasFnAttribute("uniform-work-group-size")) {
+ if (Callee->hasFnAttribute("uniform-work-group-size")) {
+ Attribute attr = Callee->getFnAttribute("uniform-work-group-size");
----------------
arsenm wrote:
> I don't see how this prevents propagating the attribute if other callers do not have it
By other callers, do you mean other kernel function?
AttrNames[] does not include "uniform-work-group-size" in the list so it wouldn't get copied to other kernel functions form the callee function.
https://reviews.llvm.org/D50200
More information about the llvm-commits
mailing list