[PATCH] D50820: [VPlan] Implement initial vector code generation support for simple outer loops.

Robin Kruppe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 11 09:15:58 PDT 2018


rkruppe added a comment.

I think I found a typo, but otherwise LGTM too!



================
Comment at: lib/Transforms/Vectorize/VPlan.cpp:392
+    for (VPBlockBase *SuccVPBlock : VPBB->getHierarchicalSuccessors()) {
+      VPBasicBlock *SuccVPBB = SuccVPBlock->getExitBasicBlock();
+      BBTerminator->setSuccessor(Idx, State->CFG.VPBB2IRBB[SuccVPBB]);
----------------
Shouldn't this call `getEntryBasicBlock()`? If the successor is a region, the corresponding IR block should jump to the entry block of that region, not to its exit.


Repository:
  rL LLVM

https://reviews.llvm.org/D50820





More information about the llvm-commits mailing list