[PATCH] D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands

[David Stuttard via Phabricator via llvm-commits]

dstuttard created this revision.
Herald added subscribers: llvm-commits, t-tye, tpr, yaxunl, mgorny, nhaehnle, wdng, jvesely, kzhuravl, arsenm.

Even though writelane doesn't have the same constraints as other valu
instructions it still can't violate the >1 SGPR operand constraint

Due to later register propagation (e.g. fixing up vgpr operands via
readfirstlane) changing writelane to only have a single SGPR is tricky.

This implementation puts a new check after SIFixSGPRCopies that prevents
multiple SGPRs being used in any writelane instructions.

The algorithm used is to check for trivial copy prop of suitable constants into
one of the SGPR operands and perform that if possible. If this isn't possible
put an explicit copy of Src1 SGPR into M0 and use that instead (this is
allowable for writelane as the constraint is for SGPR read-port and not
constant-bus access).


Repository:
  rL LLVM

https://reviews.llvm.org/D51932

Files:
  lib/Target/AMDGPU/SIFixSGPRCopies.cpp
  lib/Target/AMDGPU/SIPeepholeSDWA.cpp
  lib/Target/AMDGPU/Utils/AMDGPUMCUtils.cpp
  lib/Target/AMDGPU/Utils/AMDGPUMCUtils.h
  lib/Target/AMDGPU/Utils/CMakeLists.txt
  test/CodeGen/AMDGPU/llvm.amdgcn.writelane.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51932.164878.patch
Type: text/x-patch
Size: 11737 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180911/6cce1878/attachment-0001.bin>