[PATCH] D51887: lld-link: Set PDB GUID to hash of PDB contents instead of to a random byte sequence.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 11 07:27:38 PDT 2018


thakis added a comment.

In https://reviews.llvm.org/D51887#1230485, @thakis wrote:

> (I don't understand yet how /pdbaltpath: makes it into the hash)


(That's because EnvBlockSym's cmd stores the the linker args under the "cmd" entry, so all flags appear in the pdb. So rsds.test can't use different /pdbaltpath:s if it expects the guids to match. All that's left now is to collect perf data with both approaches.)


https://reviews.llvm.org/D51887





More information about the llvm-commits mailing list