[PATCH] D51913: [libFuzzer] [Windows] Include windows.h and psapi.h with lowercase

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D51913#1230094, @smeenai wrote:

> The existing capitalization (as in before your change) is the correct one for these headers in the Windows SDK, and it's also possible to cross-compile against the Windows SDK on a case-sensitive filesystem. However, doing that cross-compilation requires using a VFS overlay or case-correcting symlinks or ciopfs or whatever anyway, because the casing in the rest of the Windows SDK is hopelessly broken, so I'm okay with this change. I'll let @rnk confirm that it's okay to change the capitalization to the non-Windows SDK form though, and I'm also CCing @zturner since he also did cross-compilation work against the Windows SDK on Linux.


And fwiw about casing, within compiler-rt we already seem to have 63 occasions of lowercase windows.h and 1 occasion of lowercase psapi.h, so this change just brings these new cases in line with the existing status quo.

The day the windows sdk actually has self-consistent casing (and in case that casing isn't all lowercase), and people migrate code for cross-building towards using that spelling consistently, I guess mingw-w64 will have to start providing such casing as well in the form of symlinks.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51913