[PATCH] D50377: [MustExecute] Rework LoopSafetyInfo to make it more optimistic about throws

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 22:04:41 PDT 2018


mkazantsev planned changes to this revision.
mkazantsev added a comment.

After digging deeper into the code, I grow more and more convinced that there was no bug to start with, and dangling pointers to instructions that are not tracked by ICF's map (even if they are tracked by OrderedInstructions) cause no problems.

I need to revisit the underlying patches, state clearly when we need to invalidate the ICF. My plan is to discard all invalidation from this code (except for guard motion). It was initially no bug there, and now the attempt to win this non-existent bug has made the code totally unreadable.


https://reviews.llvm.org/D50377





More information about the llvm-commits mailing list