[PATCH] D51891: [WebAssembly][NFC] Enable explicit locals in simd-arith.ll

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 18:37:18 PDT 2018


aheejin added a subscriber: aardappel.
aheejin added a comment.

I'm not actually sure if removing `-wasm-disable-explicit-locals` or `-wasm-keep-registers` from test cases is a direction we should head towards, because that generally makes test cases harder to read, as @aardappel https://reviews.llvm.org/D51459. Especially removing `-wasm-keep-registers` makes writing test cases very hard. Leaving these options as they are and assign 0 as a fake opcode to `TEE_LOCAL` might be an option too, as I suggested the other day. But that's just how I feel, and I'm not sure if we agreed on gradually removing those options from the test cases. What do you think, @dschuff and @aardappel ?


Repository:
  rL LLVM

https://reviews.llvm.org/D51891





More information about the llvm-commits mailing list