[PATCH] D51879: [ASan] [MinGW] Avoid including headers for functions that will be redefined
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 10 16:40:07 PDT 2018
rnk added a comment.
ಠ_ಠ mm_malloc.h, you are a source of much complexity.
================
Comment at: lib/asan/asan_malloc_win.cc:28
#define WIN32_LEAN_AND_MEAN
#include <windows.h>
----------------
How badly do we need this include? It looks like we only get it for a few typedefs like HANDLE, LPVOID, and some other stuff that we could avoid without too much work. This file is intentionally isolated to avoid these kinds of conflicts. Should we just isolate it from windows.h too?
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D51879
More information about the llvm-commits
mailing list