[PATCH] D51550: Use alias analysis to check for real interference in cascade comparison

Christy Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 15:48:25 PDT 2018


christylee added inline comments.


================
Comment at: test/Transforms/MergeICmps/X86/alias-merge-blocks.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -mergeicmps -mtriple=x86_64-unknown-unknown -S | FileCheck %s --check-prefix=X86
----------------
lebedev.ri wrote:
> christylee wrote:
> > lebedev.ri wrote:
> > > Would be good to commit the test with current check-lines, so the diff is visible in the review.
> > Hi @lebedev.ri !  Sorry I'm new to LLVM, what do you mean by "check-lines"?
> In other words, i was suggesting to commit this test file (with the correct output from
> `utils/update_test_checks.py`), so this differential would then show
> how the code change affects the test.
> 
> check-lines - the lines with prefixes specified in `--check-prefix=` of `FileCheck`, in this case, `; X86`
Is this what you mean, @lebedev.ri ?


https://reviews.llvm.org/D51550





More information about the llvm-commits mailing list