[PATCH] D51841: [llvm-objcopy] Dwarf decompression support.

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added inline comments.


================
Comment at: tools/llvm-objcopy/Object.h:366
+      : SectionBase(Sec), DoDecompression(DoDecompression) {
+    if (!DoDecompression)
+      return;
----------------
alexshap wrote:
> alexshap wrote:
> > alexshap wrote:
> > > I'm looking at the changes in OwnedDataSection, tbh, i'm not a big fan of them.
> > > It looks like OwnedDataSection is not the right place for them (now we have a bool flag and a new branch everywhere + some details (like ".zdebug") have leaked into it).  
> > one potential approach might be to create DecompressedSection class. cc: @jakehehrlich
> > (to avoid misunderstanding: ubiquitous "if(DoCompression)" or "if(Sec.DoCompression)" all over the pipeline suggest that this dispatching mechanism should not be in OwnedDataSection)
> typo: DoDecompression
+1 on this general view point. OwnedDataSection is not the right place.


Repository:
  rL LLVM

https://reviews.llvm.org/D51841