[PATCH] D51871: [lit] Disable shtest-timeout on Windows

[Stella Stamenova via Phabricator via llvm-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341856: [lit] Disable shtest-timeout on Windows (authored by stella.stamenova, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D51871?vs=164705&id=164738#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D51871

Files:
  llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg
  llvm/trunk/utils/lit/tests/shtest-timeout.py


Index: llvm/trunk/utils/lit/tests/shtest-timeout.py
===================================================================
--- llvm/trunk/utils/lit/tests/shtest-timeout.py
+++ llvm/trunk/utils/lit/tests/shtest-timeout.py
@@ -1,7 +1,7 @@
 # REQUIRES: python-psutil
 
-# PR33944
-# XFAIL: windows
+# llvm.org/PR33944
+# REQUIRES: nowindows
 
 # FIXME: This test is fragile because it relies on time which can
 # be affected by system performance. In particular we are currently
Index: llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg
===================================================================
--- llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg
+++ llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg
@@ -13,9 +13,7 @@
     externalShell = False
 else:
     lit_config.note('Using external shell')
-    externalShell = (not sys.platform in ['win32'])
-    if not externalShell:
-        lit_config.note('External shell requested, but using internal shell')
+    externalShell = True
 
 configSetTimeout = lit_config.params.get('set_timeout', '0')
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51871.164738.patch
Type: text/x-patch
Size: 1075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180910/7aa5bc9e/attachment.bin>