[PATCH] D51836: [bugpoint] Fix TempFile scoping bug

[Don Hinton via Phabricator via llvm-commits]

hintonda added inline comments.


================
Comment at: tools/bugpoint/ExecutionDriver.cpp:439
   Expected<std::string> Output =
       executeProgram(Program, "", BitcodeFile, SharedObject, nullptr);
   if (Error E = Output.takeError())
----------------
Meinersbur wrote:
> hintonda wrote:
> > Meinersbur wrote:
> > > [serious] Here is another call to `executeProgram`. `BitcodeFile` can be empty as well (e.g. `BugDriver.cpp:218`) which will fail if only `executeProgramSafely` handles creating the bitcode file.
> > Yes, you're correct.  Looks like just rolling back r318459 with a note that you can't use TempFile in this case.  Does that sound like the correct fix?
> Have you considered wrapping `executeProgram` inside a function that creates (and discards) the bitfile (instead of hoisting that code into `executeProgramSafely`)?
I could do that, but we should revert r318459 first -- that change introduced a bug.


Repository:
  rL LLVM

https://reviews.llvm.org/D51836