[PATCH] D51872: isPodLike: handle tuple and array

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 13:02:27 PDT 2018


ldionne added inline comments.


================
Comment at: include/llvm/Support/type_traits.h:59
+template <> struct isPodLike<std::tuple<>> { static const bool value = true; };
+template <typename T> struct isPodLike<std::tuple<T>> {
+  static const bool value = isPodLike<T>::value;
----------------
ldionne wrote:
> I'm not sure what the intent is, but `std::tuple` is not a POD even when its elements are -- it typically applies the EBO and I'm pretty sure it could actually use other tricks that would not make it a POD. Specifically, that would make it not Standard Layout AFAICT. 
https://wandbox.org/permlink/uTOa0CFb15ZBQby0


Repository:
  rL LLVM

https://reviews.llvm.org/D51872





More information about the llvm-commits mailing list