[PATCH] D51835: [ADT] Support converting to lowercase string in toHex

[Petr Hosek via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL341852: [ADT] Support converting to lowercase string in toHex (authored by phosek, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D51835?vs=164607&id=164729#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D51835

Files:
  llvm/trunk/include/llvm/ADT/StringExtras.h
  llvm/trunk/unittests/ADT/StringExtrasTest.cpp


Index: llvm/trunk/include/llvm/ADT/StringExtras.h
===================================================================
--- llvm/trunk/include/llvm/ADT/StringExtras.h
+++ llvm/trunk/include/llvm/ADT/StringExtras.h
@@ -139,22 +139,23 @@
 
 /// Convert buffer \p Input to its hexadecimal representation.
 /// The returned string is double the size of \p Input.
-inline std::string toHex(StringRef Input) {
+inline std::string toHex(StringRef Input, bool LowerCase = false) {
   static const char *const LUT = "0123456789ABCDEF";
+  const uint8_t Offset = LowerCase ? 32 : 0;
   size_t Length = Input.size();
 
   std::string Output;
   Output.reserve(2 * Length);
   for (size_t i = 0; i < Length; ++i) {
     const unsigned char c = Input[i];
-    Output.push_back(LUT[c >> 4]);
-    Output.push_back(LUT[c & 15]);
+    Output.push_back(LUT[c >> 4] | Offset);
+    Output.push_back(LUT[c & 15] | Offset);
   }
   return Output;
 }
 
-inline std::string toHex(ArrayRef<uint8_t> Input) {
-  return toHex(toStringRef(Input));
+inline std::string toHex(ArrayRef<uint8_t> Input, bool LowerCase = false) {
+  return toHex(toStringRef(Input), LowerCase);
 }
 
 inline uint8_t hexFromNibbles(char MSB, char LSB) {
Index: llvm/trunk/unittests/ADT/StringExtrasTest.cpp
===================================================================
--- llvm/trunk/unittests/ADT/StringExtrasTest.cpp
+++ llvm/trunk/unittests/ADT/StringExtrasTest.cpp
@@ -70,13 +70,15 @@
                     OddBytes.size());
   EXPECT_EQ(OddStr, toHex(OddData));
   EXPECT_EQ(OddData, fromHex(StringRef(OddStr).drop_front()));
+  EXPECT_EQ(StringRef(OddStr).lower(), toHex(OddData, true));
 
   std::vector<uint8_t> EvenBytes = {0xA5, 0xBD, 0x0D, 0x3E, 0xCD};
   std::string EvenStr = "A5BD0D3ECD";
   StringRef EvenData(reinterpret_cast<const char *>(EvenBytes.data()),
                      EvenBytes.size());
   EXPECT_EQ(EvenStr, toHex(EvenData));
   EXPECT_EQ(EvenData, fromHex(EvenStr));
+  EXPECT_EQ(StringRef(EvenStr).lower(), toHex(EvenData, true));
 }
 
 TEST(StringExtrasTest, to_float) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51835.164729.patch
Type: text/x-patch
Size: 2058 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180910/d5eb41a8/attachment.bin>