[PATCH] D51842: [X86ISel] Implement byval lowering for Win64 calling convention

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with a tweaked comment. Thanks!



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3625
+      if (isByVal) {
+        // Copy the argument into a temportary spill slot
+        int FrameIdx = MF.getFrameInfo().CreateStackObject(
----------------
I wouldn't call this a spill slot, I would say, copy the argument so that the caller does not see modifications.


Repository:
  rL LLVM

https://reviews.llvm.org/D51842