[PATCH] D51871: [lit] Disable shtest-timeout on Windows

[Zachary Turner via llvm-commits]

Lgtm
On Mon, Sep 10, 2018 at 11:16 AM Stella Stamenova via Phabricator <
reviews at reviews.llvm.org> wrote:

> stella.stamenova created this revision.
> stella.stamenova added reviewers: asmith, delcypher, zturner.
> Herald added a subscriber: llvm-commits.
>
> This is the only test that is still failing on Windows - or rather, it is
> expected to fail on the bots, but passes on the new bot that we're
> preparing causing a failure, so I'm going to disable it. Since the test has
> rarely, if ever, passed on the bots, this should have the same effect and
> it will unblock the creation of the new bot.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D51871
>
> Files:
>   utils/lit/tests/Inputs/shtest-timeout/lit.cfg
>   utils/lit/tests/shtest-timeout.py
>
>
> Index: utils/lit/tests/shtest-timeout.py
> ===================================================================
> --- utils/lit/tests/shtest-timeout.py
> +++ utils/lit/tests/shtest-timeout.py
> @@ -1,7 +1,7 @@
>  # REQUIRES: python-psutil
>
> -# PR33944
> -# XFAIL: windows
> +# llvm.org/PR33944
> +# REQUIRES: nowindows
>
>  # FIXME: This test is fragile because it relies on time which can
>  # be affected by system performance. In particular we are currently
> Index: utils/lit/tests/Inputs/shtest-timeout/lit.cfg
> ===================================================================
> --- utils/lit/tests/Inputs/shtest-timeout/lit.cfg
> +++ utils/lit/tests/Inputs/shtest-timeout/lit.cfg
> @@ -13,9 +13,7 @@
>      externalShell = False
>  else:
>      lit_config.note('Using external shell')
> -    externalShell = (not sys.platform in ['win32'])
> -    if not externalShell:
> -        lit_config.note('External shell requested, but using internal
> shell')
> +    externalShell = True
>
>  configSetTimeout = lit_config.params.get('set_timeout', '0')
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180910/f4af5535/attachment-0001.html>