[PATCH] D43515: More math intrinsics for conservative math handling

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 10:31:37 PDT 2018


craig.topper added a comment.

Adding new constrained instrinsics and adding the pass should be separate patches I think. Changing the syntax of frem should be another patch.



================
Comment at: docs/LangRef.rst:13888
       @llvm.experimental.constrained.frem(<type> <op1>, <type> <op2>,
-                                          metadata <rounding mode>,
                                           metadata <exception behavior>)
----------------
This change should be in a separate patch. There's too much going on in this patch and this is easy to overlook.


https://reviews.llvm.org/D43515





More information about the llvm-commits mailing list